adventure: don't strand an order on a database blip, don't misroute a tap
Two things a code review turned up in the W9 seams. The verdict handler answered 400 for everything ResolveAdvOrder could fail with, not just a bad verdict. gogobee's contract says a 400 means "park this row for a human", so a SQLite busy or a disk hiccup permanently stranded an extract or a bout that was perfectly resolvable. Split the two apart with ErrBadAdvVerdict: a verdict outside the terminal set is still 400, because gogobee will never send it successfully, and a genuine storage failure is now 500 and comes back on the next poll. The push URL builders concatenated the guid and the run id raw, while every other builder beside them path-escapes because these values arrive over a wire. A guid carrying a slash sent the notification tap to a different page.
This commit is contained in:
+10
-2
@@ -336,11 +336,19 @@ func (s *Server) handleAdvOrderVerdict(w http.ResponseWriter, r *http.Request) {
|
||||
http.Error(w, "no such order", http.StatusBadRequest)
|
||||
return
|
||||
}
|
||||
if err != nil {
|
||||
slog.Error("orders: resolve", "guid", v.GUID, "status", v.Status, "err", err)
|
||||
if errors.Is(err, storage.ErrBadAdvVerdict) {
|
||||
slog.Error("orders: verdict outside the terminal set", "guid", v.GUID, "status", v.Status)
|
||||
http.Error(w, "bad verdict", http.StatusBadRequest)
|
||||
return
|
||||
}
|
||||
if err != nil {
|
||||
// A storage failure, not a bad request. 400 here would park a perfectly
|
||||
// resolvable order forever on a transient database error; 500 gets it
|
||||
// retried on gogobee's next poll.
|
||||
slog.Error("orders: resolve", "guid", v.GUID, "status", v.Status, "err", err)
|
||||
http.Error(w, "internal error", http.StatusInternalServerError)
|
||||
return
|
||||
}
|
||||
slog.Info("orders: action resolved", "guid", order.GUID, "action", order.Action, "status", order.Status)
|
||||
writeJSON(w, order)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user