Expedition autopilot Phase 4 + rogue sneak attack + TwinBee voice sweep

Tedium-removal pass driven by live play feedback. Three big threads:

Expedition autopilot Phase 4 — background auto-run + harvest-until-dry:
- New expeditionAutoRunTicker walks active expeditions every 15min
  (5min tick, per-expedition CAS on new last_autorun_at column). Skips
  combat sessions, briefing/recap quiet windows, expeditions <30min old.
- Walks up to 3 rooms/tick with compact narration; suppresses DMs when
  0 rooms walked or just hitting the per-tick cap (no "stretch complete"
  filler). Player only hears from the bot when a real decision is needed.
- Compact mode: one-line combat narration for trash/elite, auto-resolves
  elite doorways via the forward-sim engine (boss still pauses). Threaded
  via new advanceOnceWithOpts → resolveRoom → resolveCombatRoom.
- Auto-harvest now grinds each Common/Uncommon node until dry (cap at 8
  attempts/visit), mirroring manual !scavenge retries. Rare+ still pauses.
- Ambient ticker: anti-repeat by Kind via new last_ambient_kind column
  (avoids two pack_rat DMs in a row when the pool only has 6 lines).
- !expedition go <n> now routes to the fork-choice handler when active +
  numeric; fork footer rewritten to suggest !expedition go instead of
  !zone go. Boss/Elite doorway: formatNextRoomMessage routes the action
  hint by next room type and autopilot loop breaks via new nextRoomType
  field so "Room X/Y — Boss" doesn't double-print with contradictory
  hints (!zone advance vs !fight).
- runAutopilotWalk extracted from expeditionCmdRun so foreground and
  background share the loop body.

Rogue Sneak Attack actually exists now:
- Audit found the rogue's "Sneak Attack" passive was AutoCritFirst +
  5% damage rider. No Nd6, ever. Phase 2 Monte Carlo masked this
  with a small flat buff; the class's defining mechanic never matched
  its tooltip or 5e identity.
- Added SneakAttackDie int to CombatModifiers, per-hit Nd6 in
  combat_primitives.go (same lane as DivineStrikePerHit). Scales with
  level: 1d6 at L1-2 ... 4d6 at L7-8 ... capped at 10d6 at L19-20.
- AutoCritFirst + 5% rider retained as bonuses on top of working sneak
  attack — preserves the opener-burst feel.
- L7 rogue expected per-hit ~8 → ~22 damage. Valdris fight math goes
  from "16 rounds to kill, die in 8" to winnable.

TwinBee voice sweep (Phase B3):
- ~530 line changes across 24 files replacing third-person "TwinBee
  notes/files/tracks/respects/..." constructions with first-person
  inside flavor string literals. Code identifiers (TwinBeeLine,
  twinBeeLine, etc.), chat-prefix labels (🎭 **TwinBee:**), item names
  (TwinBee's Bell), achievements, and game-title references in
  fun.go (Konami TwinBee ship) left intact.
- Catches a real bug: Valdris fight rendered "TwinBee marks the
  Legendary Resistance" mid-combat in third person, contradicting
  the Phase B2 convention.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
prosolis
2026-05-16 12:40:17 -07:00
parent f424300d87
commit 41adfce9f1
39 changed files with 1133 additions and 638 deletions

View File

@@ -50,7 +50,7 @@ func TestPickAmbientEvent_AlwaysReturnsEligible(t *testing.T) {
}
for i := 0; i < 200; i++ {
rng := rand.New(rand.NewPCG(uint64(i), uint64(i*7+1)))
ev := pickAmbientEvent(e, rng)
ev := pickAmbientEvent(e, rng, "")
if disallowed[ev.Kind] {
t.Fatalf("seed %d picked ineligible event %q", i, ev.Kind)
}
@@ -66,7 +66,7 @@ func TestPickAmbientEvent_CampVisitorRequiresCamp(t *testing.T) {
sawVisitor := false
for i := 0; i < 500; i++ {
rng := rand.New(rand.NewPCG(uint64(i+1), uint64(i*13+2)))
if pickAmbientEvent(e, rng).Kind == "camp_visitor" {
if pickAmbientEvent(e, rng, "").Kind == "camp_visitor" {
sawVisitor = true
break
}
@@ -82,7 +82,7 @@ func TestPickAmbientEvent_PackRatNeedsSupplies(t *testing.T) {
e := &Expedition{Supplies: ExpeditionSupplies{Current: 0}}
for i := 0; i < 200; i++ {
rng := rand.New(rand.NewPCG(uint64(i+3), uint64(i*5+7)))
if pickAmbientEvent(e, rng).Kind == "pack_rat" {
if pickAmbientEvent(e, rng, "").Kind == "pack_rat" {
t.Fatalf("seed %d: pack_rat fired with no supplies", i)
}
}
@@ -92,7 +92,7 @@ func TestPickAmbientEvent_WhisperNeedsThreat(t *testing.T) {
low := &Expedition{Supplies: ExpeditionSupplies{Current: 5}, ThreatLevel: 10}
for i := 0; i < 200; i++ {
rng := rand.New(rand.NewPCG(uint64(i+5), uint64(i*11+3)))
if pickAmbientEvent(low, rng).Kind == "faction_whisper" {
if pickAmbientEvent(low, rng, "").Kind == "faction_whisper" {
t.Fatalf("seed %d: whisper fired below threshold", i)
}
}
@@ -100,7 +100,7 @@ func TestPickAmbientEvent_WhisperNeedsThreat(t *testing.T) {
saw := false
for i := 0; i < 500; i++ {
rng := rand.New(rand.NewPCG(uint64(i+9), uint64(i*17+5)))
if pickAmbientEvent(hot, rng).Kind == "faction_whisper" {
if pickAmbientEvent(hot, rng, "").Kind == "faction_whisper" {
saw = true
break
}
@@ -120,12 +120,41 @@ func TestPickAmbientEvent_SiegeSuppressesWhisper(t *testing.T) {
}
for i := 0; i < 200; i++ {
rng := rand.New(rand.NewPCG(uint64(i+13), uint64(i*19+11)))
if pickAmbientEvent(e, rng).Kind == "faction_whisper" {
if pickAmbientEvent(e, rng, "").Kind == "faction_whisper" {
t.Fatalf("seed %d: whisper fired during siege", i)
}
}
}
func TestPickAmbientEvent_AntiRepeatRerollsOnce(t *testing.T) {
// When the first roll lands on avoidKind, we re-roll once. We can't
// guarantee the second roll diverges (the same Kind can win twice
// legitimately), but across many seeds the same-Kind repeat rate
// must drop materially vs the no-avoid baseline.
e := &Expedition{Supplies: ExpeditionSupplies{Current: 5}}
const trials = 2000
baseline := 0 // Kind == "pack_rat" with no avoid
guarded := 0 // Kind == "pack_rat" with avoidKind == "pack_rat"
for i := 0; i < trials; i++ {
seedA := uint64(i*2 + 1)
seedB := uint64(i*2 + 2)
if pickAmbientEvent(e, rand.New(rand.NewPCG(seedA, seedB)), "").Kind == "pack_rat" {
baseline++
}
if pickAmbientEvent(e, rand.New(rand.NewPCG(seedA, seedB)), "pack_rat").Kind == "pack_rat" {
guarded++
}
}
if guarded >= baseline {
t.Fatalf("anti-repeat did not reduce pack_rat hits: baseline=%d guarded=%d", baseline, guarded)
}
// Sanity: the guarded count should be small (≈ baseline²/total), not
// just one less. Allow generous slack but flag obvious regressions.
if guarded*3 > baseline {
t.Errorf("anti-repeat reduction weaker than expected: baseline=%d guarded=%d", baseline, guarded)
}
}
func TestRenderAmbientDM_NoFooterPureFlavor(t *testing.T) {
e := &Expedition{CurrentDay: 4}
ev := ambientEventMonologue()