drwily/gogobee
1
0
Fork 0
mirror of https://github.com/prosolis/gogobee.git synced 2026-07-16 08:52:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adv 2.0 post-L5 audit cleanup: drop redundant dual-writes + refresh stale comments

Browse Source 
Audit confirmed saveAdvCharacter's fan-out (upsertAllPlayerMetaFromAdvChar)
covers all 13 migrated subsystems, so the per-call-site upsertPlayerMetaXxx
calls retained "as defense" through the L4-L5 migration are redundant
post-L5h. Removed 16 such call sites across arena (2), scheduler (4),
hospital (1), consumables (2), rival (1), housing (11), and reordered
masterwork to drop a now-pointless explicit upsert before the load+save.

Refreshed nine stale doc comments referencing the legacy
adventure_characters table or "soak window / fallback" language that no
longer applies after the L5 close-out (commit 596b2b7). No behavior
change; go vet + go test ./... pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
prosolis
2026-05-09 13:01:00 -07:00
parent c0f03a41b5
commit 5d98e5684a
11 changed files with 27 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/plugin/adventure_arena.go
View File

@@ -468,13 +468,6 @@ func (p *AdventurePlugin) resolveArenaDeath(ctx MessageContext, run *ArenaRun, c
if err := saveAdvCharacter(char); err != nil {
slog.Error("arena: failed to save character after death", "user", ctx.Sender, "err", err)
}
// Dual-write to player_meta (Adv 2.0 Phase L2 step 5).
if err := upsertPlayerMetaArena(ctx.Sender, char.ArenaWins, char.ArenaLosses, char.InvasionScore); err != nil {
slog.Error("player_meta: arena loss dual-write failed", "user", ctx.Sender, "err", err)
}
if err := upsertPlayerMetaSkillState(ctx.Sender, skillStateFromAdvChar(char)); err != nil {
slog.Error("player_meta: arena loss skill dual-write failed", "user", ctx.Sender, "err", err)
}
now := time.Now().UTC()
run.Status = "dead"
@@ -550,13 +543,6 @@ func (p *AdventurePlugin) arenaCompleteSession(userID id.UserID, run *ArenaRun,
if err := saveAdvCharacter(char); err != nil {
slog.Error("arena: failed to save character after session complete", "user", userID, "err", err)
}
// Dual-write to player_meta (Adv 2.0 Phase L2 step 5).
if err := upsertPlayerMetaArena(userID, char.ArenaWins, char.ArenaLosses, char.InvasionScore); err != nil {
slog.Error("player_meta: arena win dual-write failed", "user", userID, "err", err)
}
if err := upsertPlayerMetaSkillState(userID, skillStateFromAdvChar(char)); err != nil {
slog.Error("player_meta: arena win skill dual-write failed", "user", userID, "err", err)
}
// End run if not already ended
if run.Status != "completed" && run.Status != "cashed_out" {