drwily/gogobee
1
0
Fork 0
mirror of https://github.com/prosolis/gogobee.git synced 2026-07-15 16:42:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adv 2.0 post-L5 audit cleanup: drop redundant dual-writes + refresh stale comments

Browse Source 
Audit confirmed saveAdvCharacter's fan-out (upsertAllPlayerMetaFromAdvChar)
covers all 13 migrated subsystems, so the per-call-site upsertPlayerMetaXxx
calls retained "as defense" through the L4-L5 migration are redundant
post-L5h. Removed 16 such call sites across arena (2), scheduler (4),
hospital (1), consumables (2), rival (1), housing (11), and reordered
masterwork to drop a now-pointless explicit upsert before the load+save.

Refreshed nine stale doc comments referencing the legacy
adventure_characters table or "soak window / fallback" language that no
longer applies after the L5 close-out (commit 596b2b7). No behavior
change; go vet + go test ./... pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
prosolis
2026-05-09 13:01:00 -07:00
parent c0f03a41b5
commit 5d98e5684a
11 changed files with 27 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/plugin/adventure_masterwork.go
View File

@@ -193,24 +193,17 @@ func (p *AdventurePlugin) checkMasterworkDrop(userID id.UserID, equip map[Equipm
autoEquip = true // genuinely better than what they have
}
// First-drop detection. Read via player_meta (L4c migration); during
// soak it falls back to AdvCharacter for users whose row hasn't been
// dual-written yet.
// First-drop detection. Counter persists via saveAdvCharacter fan-out.
priorDrops, err := loadMasterworkDrops(userID)
if err != nil {
slog.Error("adventure: failed to load masterwork counter", "user", userID, "err", err)
}
isFirstDrop := priorDrops == 0
newDrops := priorDrops + 1
if err := upsertPlayerMetaMasterworkDrops(userID, newDrops); err != nil {
slog.Error("adventure: failed to save masterwork counter (player_meta)", "user", userID, "err", err)
}
// Dual-write to AdvCharacter during soak. Best-effort: if the row is
// missing the player_meta write above is canonical.
if char, lerr := loadAdvCharacter(userID); lerr == nil {
char.MasterworkDropsReceived = newDrops
if err := saveAdvCharacter(char); err != nil {
slog.Error("adventure: failed to save masterwork counter (legacy)", "user", userID, "err", err)
slog.Error("adventure: failed to save masterwork counter", "user", userID, "err", err)
}
}