drwily/gogobee
1
0
Fork 0
mirror of https://github.com/prosolis/gogobee.git synced 2026-07-16 17:02:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adv 2.0 post-L5 audit cleanup: drop redundant dual-writes + refresh stale comments

Browse Source 
Audit confirmed saveAdvCharacter's fan-out (upsertAllPlayerMetaFromAdvChar)
covers all 13 migrated subsystems, so the per-call-site upsertPlayerMetaXxx
calls retained "as defense" through the L4-L5 migration are redundant
post-L5h. Removed 16 such call sites across arena (2), scheduler (4),
hospital (1), consumables (2), rival (1), housing (11), and reordered
masterwork to drop a now-pointless explicit upsert before the load+save.

Refreshed nine stale doc comments referencing the legacy
adventure_characters table or "soak window / fallback" language that no
longer applies after the L5 close-out (commit 596b2b7). No behavior
change; go vet + go test ./... pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
prosolis
2026-05-09 13:01:00 -07:00
parent c0f03a41b5
commit 5d98e5684a
11 changed files with 27 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
internal/plugin/adventure_scheduler.go
View File

@@ -95,7 +95,6 @@ func (p *AdventurePlugin) sendMorningDMs() {
if err := saveAdvCharacter(&char); err != nil {
slog.Error("babysit: failed to save after daily trickle", "user", char.UserID, "err", err)
}
_ = upsertPlayerMetaPetState(char.UserID, petStateFromAdvChar(&char))
continue
}
@@ -127,7 +126,6 @@ func (p *AdventurePlugin) sendMorningDMs() {
if petEvent != "" {
char.PetMorningDefense = true
_ = saveAdvCharacter(&char)
_ = upsertPlayerMetaPetState(char.UserID, petStateFromAdvChar(&char))
}
// Send morning DM with choices
@@ -388,7 +386,6 @@ func (p *AdventurePlugin) midnightReset() error {
text += " — not all is lost."
}
_ = saveAdvCharacter(&char)
_ = upsertPlayerMetaLifecycleState(char.UserID, lifecycleStateFromAdvChar(&char))
}
if err := p.SendDM(char.UserID, text); err != nil {
slog.Error("adventure: failed to send idle shame DM", "user", char.UserID, "err", err)
@@ -405,7 +402,6 @@ func (p *AdventurePlugin) midnightReset() error {
char.BestStreak = char.CurrentStreak
}
_ = saveAdvCharacter(&char)
_ = upsertPlayerMetaLifecycleState(char.UserID, lifecycleStateFromAdvChar(&char))
}
}