drwily/gogobee
1
0
Fork 0
mirror of https://github.com/prosolis/gogobee.git synced 2026-07-16 08:52:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adv 2.0 post-L5 audit cleanup: drop redundant dual-writes + refresh stale comments

Browse Source 
Audit confirmed saveAdvCharacter's fan-out (upsertAllPlayerMetaFromAdvChar)
covers all 13 migrated subsystems, so the per-call-site upsertPlayerMetaXxx
calls retained "as defense" through the L4-L5 migration are redundant
post-L5h. Removed 16 such call sites across arena (2), scheduler (4),
hospital (1), consumables (2), rival (1), housing (11), and reordered
masterwork to drop a now-pointless explicit upsert before the load+save.

Refreshed nine stale doc comments referencing the legacy
adventure_characters table or "soak window / fallback" language that no
longer applies after the L5 close-out (commit 596b2b7). No behavior
change; go vet + go test ./... pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
prosolis
2026-05-09 13:01:00 -07:00
parent c0f03a41b5
commit 5d98e5684a
11 changed files with 27 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/plugin/dnd_sheet.go
View File

@@ -42,10 +42,10 @@ func (p *AdventurePlugin) handleDnDAbilitiesCmd(ctx MessageContext) error {
// !sheet — read-only D&D character sheet renderer.
//
// Joins:
// Sources:
// dnd_character (D&D layer)
// adventure_characters (legacy skills, pet, housing — for at-a-glance context)
// adventure_equipment (current gear; renders with legacy fields until Phase 4)
// player_meta (skills, pet, housing — for at-a-glance context)
// adventure_equipment (current gear)
// adventure_treasures (= attunement substrate per v1.1 §7.4)
func (p *AdventurePlugin) handleDnDSheetCmd(ctx MessageContext) error {