Phase 5b: player power floor + Phase-3 winners shipped to live

Closes the 'fairly breezy with some death' target the user picked
for Phase 5. Five-piece ship; Phase 1 matrix lands T1 88%, T2 74%,
T4 72%, T5 ~57% in or above band. T3 remains the design hump at
~45% (manor 39, underforge 47) — Wraith promotion to elite was
already done in Phase 4-B, the remaining standard-pool deaths are
the irreducible part of T3.

Pieces:
  1. computeMaxHP × 1.5 (phase5BHPMult in dnd.go). Uniform across
     class/level so the class-balance harness's in-tier parity
     assertion stays green. Bootstrap (bootstrap_phase5b_hp.go)
     refreshes hp_max for existing characters at startup;
     idempotent via db.JobCompleted. hp_current is bumped by the
     same delta so a full-HP character stays at full.
  2. applyPhase5BPlayerFloor (dnd_combat.go): +3 AC, +3 AttackBonus,
     +3 weapon.MagicBonus (damage). Applied at the END of
     applyDnDEquipmentLayer (after computeArmorAC's AC override)
     and inside buildHarnessPlayer so live and harness measurement
     match.
  3. Elite bracket 19 → 23 (resolveCombatInterrupt). Case order
     puts Elite (≥23) before Patrol (≥22) so a 23+ total prefers
     the single dangerous fight. Elite is now effectively a
     high-threat event reachable only via the +1-per-20-threat-
     above-40 mod — Phase 4-B's elite-pool monsters still appear,
     just less often.
  4. dailyThreatDrift base 3 → 1. Slows the threat clock so
     players have the days they need before threat tips zones
     into the new 23+ elite band.
  5. applyDailyBurn default → 50% (phase5BDailyBurnRatePct). Also
     applied in the temporal-override branch in
     dnd_expedition_cycle.go so tidal / unraveling days scale by
     the same 0.5× — otherwise those days would be
     disproportionately harsh against the new baseline.

The harness's expedition_balance.go reads phase5BDailyBurnRatePct
as the default-burn fallback when the override knob is zero, so
Phase 1 matrix measurements now reflect what live players
experience.

Test debt: 13 pinned-numbers unit tests across combat_stats_test,
dnd_test, dnd_xp_test, dnd_equipment_profiles_test,
dnd_expedition_supplies_test, dnd_expedition_cycle_test,
dnd_expedition_extract_test, dnd_expedition_region_cmd_test,
dnd_expedition_combat_test, dnd_expedition_threat_test,
dnd_expedition_temporal_test, expedition_balance_test were
pinning pre-Phase-5-B baselines; updated with comments noting
the cause. Class-balance suite stayed green (uniform buff
preserves spread).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
prosolis
2026-05-15 12:11:27 -07:00
parent d0a8505c76
commit 5ef10e35dc
23 changed files with 627 additions and 94 deletions

View File

@@ -51,15 +51,19 @@ func TestThreatBandInfo_SiegeFlags(t *testing.T) {
}
func TestDailyThreatDrift_MoodMod(t *testing.T) {
// Phase 5-B: base threat drift lowered from 3 to 1 to slow the
// threat clock (paired with the player floor + supply burn cut).
// All expected values shift by -2 (base 3 → 1) but the mood-mod
// shape is unchanged.
cases := []struct {
mood int
want int
}{
{50, 3}, // neutral
{60, 3}, // friendly (still neutral for threat)
{80, 0}, // effusive → elated -3
{19, 8}, // hostile → wrathful +5
{0, 8}, // hostile lower bound
{50, 1}, // neutral: 1 + 0
{60, 1}, // friendly (still neutral): 1 + 0
{80, -2}, // effusive → elated: 1 + -3
{19, 6}, // hostile → wrathful: 1 + 5
{0, 6}, // hostile lower bound
}
for _, c := range cases {
got, _ := dailyThreatDrift(c.mood)
@@ -79,8 +83,9 @@ func TestApplyDailyThreatDrift_PersistsAndCrossesThreshold(t *testing.T) {
if err != nil {
t.Fatal(err)
}
// Pre-load to 19 so a +3 drift crosses Stirring boundary.
if err := applyThreatDelta(exp.ID, 19, "test seed"); err != nil {
// Phase 5-B: base drift dropped to 1. Pre-load to 20 (Quiet band) so
// the +1 drift crosses into Stirring at 21.
if err := applyThreatDelta(exp.ID, 20, "test seed"); err != nil {
t.Fatal(err)
}
exp, _ = getExpedition(exp.ID)
@@ -89,12 +94,12 @@ func TestApplyDailyThreatDrift_PersistsAndCrossesThreshold(t *testing.T) {
if err != nil {
t.Fatal(err)
}
if delta != 3 {
t.Errorf("delta = %d, want 3", delta)
if delta != 1 {
t.Errorf("delta = %d, want 1", delta)
}
got, _ := getExpedition(exp.ID)
if got.ThreatLevel != 22 {
t.Errorf("threat = %d, want 22", got.ThreatLevel)
if got.ThreatLevel != 21 {
t.Errorf("threat = %d, want 21", got.ThreatLevel)
}
// Threshold transition log entry should exist with TwinBee narration.
entries, _ := recentExpeditionLog(exp.ID, 10)
@@ -150,8 +155,8 @@ func TestDeliverBriefing_AppliesThreatDrift(t *testing.T) {
t.Fatal(err)
}
got, _ := getExpedition(exp.ID)
if got.ThreatLevel != 3 {
t.Errorf("post-briefing threat = %d, want 3 (mood-neutral drift)", got.ThreatLevel)
if got.ThreatLevel != 1 {
t.Errorf("post-briefing threat = %d, want 1 (mood-neutral drift, Phase 5-B base)", got.ThreatLevel)
}
}
@@ -165,8 +170,9 @@ func TestApplyDailyThreatDrift_LogsApproachingSiegeOnceAt70(t *testing.T) {
if err != nil {
t.Fatal(err)
}
// Seed to 68 — a +3 drift crosses 70.
if err := applyThreatDelta(exp.ID, 68, "seed"); err != nil {
// Phase 5-B: base drift dropped to 1. Seed to 69 so a +1 drift
// crosses 70 → 70.
if err := applyThreatDelta(exp.ID, 69, "seed"); err != nil {
t.Fatal(err)
}
exp, _ = getExpedition(exp.ID)