3 Commits

Author	SHA1	Message	Date
prosolis	d538f91cf7	Combat engine: pay off the N-body debt, and hire Pete ... N3 widened the combat *roster* from 1 to N but never widened the action model, the scaling model, or the test net to match. Building the hireable companion walked into all three. Only one of the four defects found was the companion's; the rest have been live in prod for every human party since N3. The party golden did not exist (§5) Solo combat is pinned exhaustively (7468 lines); the entire N-body layer had nothing. That is why a healer class that cannot heal shipped without a test going red. Adds party_characterization.golden (9 scenarios x 5 seeds, incl. weak and dying seats) and TestPartyCharacterization_OneSeatIsStillSolo, so the N-body path can never quietly stop being a superset of the balance corpus. Regenerate only on purpose: -update-party. No action could target another seat (§1) Every heal in the engine was self-scoped. A party cleric could not put one hit point on a friend. Adds turnActionEffect.AllyHeal/AllySeat, `!cast <spell> @user` and `--target @user` -- the latter has been advertised in !help and silently swallowed by parseCombatCast since SP2 ("reserved for SP3"). The auto picker uses it too (simPickAllyHeal), so away-players and engine-driven healers behave like competent ones. It will not raise the dead. Corpses kept buffing the boss (§2b) enemyActionsThisRound counted len(st.actors), dead included -- so a party that lost a member kept paying for them, and the survivor faced a boss still swinging at two-player cadence, alone. A death spiral with the arrow pointing the wrong way. Now counts livingActors(). Party golden moved deliberately for this. An engine-driven seat was a bool any command could clear (§3) autoDriveCombat drives a party by dispatching each seat's turn AS that seat, so a companion's own auto-played move arrived at beginCombatTurn looking like a player returning to the keyboard and cleared the latch that was moving him. He then stood in the fight doing nothing while the boss he had inflated killed everyone. ActorStatuses.EngineDriven is now a persisted seat property that no command clears, and the driver calls driveEngineSeat instead of impersonating. "The party" could be empty (§4) A solo expedition has no expedition_party rows, so asking the roster who was in the party answered "nobody" -- and every caller fell back to something plausible. That is how the companion got hired at level 1 for exactly the player the feature exists for. expeditionParty()/partyHumans() always include the owner. The companion himself (!expedition hire [class] / !expedition dismiss) Day 1, leader only, costs coins, role-fills the gap, globally exclusive. He is an NPC seat and must never become a player: no player_meta, no dnd_character, no inventory, no DM room -- mint him a player_meta row and ensureDnDCharacterForCombat will auto-build the news bot a real character, and he starts appearing in the graveyard and filing death notices about himself. Mail and seats are different sets: he fights, he does not get written to. Measured on millenia, n=750/arm. Before these fixes he was -28pp -- worse than no companion at all. After: solo 48.5% -> 63.9% clear (+15.3pp), with +28.0pp for trailing players and +2.0pp for leaders. Help, never a carry. The solo golden is byte-identical throughout: solo combat provably did not move, and the balance corpus is intact. Known gap: the companion cannot cast (castActionForSeat loads a sheet from the DB and he has none by design), so a hired Cleric is still just a bad fighter. Claude-Session: https://claude.ai/code/session_01J5SQZWoLmL3M3mw2XmHHdy	2026-07-11 12:39:01 -07:00
prosolis	d76c63be0c	Review follow-ups A + B: armed abilities survive the fight, supply pool serialized ... A. An armed ability lasted one round of a turn-based fight. buildZoneCombatants called applyArmedAbility, which applies an ability's mods *and* clears ArmedAbility and saves the sheet. The turn engine calls that builder again on every !attack / !cast / !consume, so round 1 fired the ability and disarmed the character, and every later round rebuilt them with none of its mods. A Berserker paid stamina for a single round of BerserkerRage / RageMeleeDmg / PhysicalResistRage / FrenzyDmgBonus. Every entry in dndActiveAbilities had the same shape. mods.BerserkerRage was not merely unread at close-out — by then it no longer existed. Split arming into its two halves: consumeArmedAbility(c) mutates: disarms, saves, returns the id. Once, at fight start. applyAbilityByID(c, id, mods) pure: no DB write, no disarm. Safe on every rebuild. (No ability's Apply writes to the character, so this really is pure.) armAbilityForFight(c, mods) consume + apply, for the auto-resolve callers that build and fight in one breath. buildZoneCombatants now takes the already-consumed id and re-applies it. The id rides on ActorStatuses.ArmedAbility, seeded per seat at fight start, so partyCombatantsForSession reproduces the ability every rebuild and the close-out can still see that a rage fired. The close-out itself: postCombatBookkeeping now carries grantCombatAchievements + persistDnDPostCombatSubclass, and all four close-outs route through it — runDungeonCombat, runZoneCombatRoster, finishCombatSession, finishPartyCombatSession. It fires on every terminal status, not just a win: a Berserker who rages and loses is still exhausted, which is what auto-resolve always did. Also: buildFightSeats and runZoneCombatRoster consumed the ability before the checks that could sit a seat out, so a downed member was disarmed for a fight they never joined. The refusals now run first. B. Six unlocked read-modify-writes against the shared supply pool. updateSupplies rewrites supplies_json wholesale, so a caller folding its delta onto an *Expedition it read earlier discards whatever landed in between. Handlers run one goroutine per event, so those writers genuinely interleave. All six now go through withExpeditionSupplies, which takes advExpeditionLock, re-reads the row, hands the closure the fresh copy and persists what it returns: nightRolloverBurn (forage + burn in one write), grantTwoWeeksCache, advanceToNextRegion's transit burn, campPitch, pitchAutopilotCamp, and the ambient pack-rat drain. expeditionCmdAccept's hand-rolled lock folds onto the same helper. expedition_sim.go is left alone: single-threaded, takes no locks. Known consequence, for the balance track: trySimAutoArm used to live inside the rebuild, so a simulated Fighter (second_wind) or Cleric (healing_word) re-armed and re-spent a resource every round of every elite/boss fight. expedition-sim drives those through the turn engine, so every prior expedition-sim corpus overstates those two classes. Re-baseline after this, not before. Claude-Session: https://claude.ai/code/session_017mEwUmmS7aQTP2NQXj6rUa	2026-07-10 08:01:51 -07:00
prosolis	b333d05443	N3/P6c: a fight the whole party sits down for ... `!fight` seats the expedition's roster instead of the one player who typed it. Seat 0 is the leader, always: the session row is theirs, the lock is theirs, and `!flee`, the fork, and `!extract` stay their call. A monster that wins initiative now swings before anyone speaks. The session layer used to park every new fight on a player_turn, which is true of the hardcoded solo order and a lie about a party's -- the enemy would forfeit round 1 and nobody would notice. `startPartyCombatSession` rolls the order and sets the phase from it; `handleFightCmd` settles the round before it announces, so the opening block narrates the hit rather than quietly showing its damage. Members were invisible to two commands that had no business ignoring them: `!cast` queued a spell for "next combat" while its caster was standing in one, and `!rest` healed a seated member to full mid boss fight. Both now resolve through the party. Nobody leaves without an answer. A downed member's `!fight` opens the party's fight and tells them why they are not in it. The leader's `!extract` reaches everyone it drags out of the dungeon, and everyone rolls for what moved into their house while they were gone. Supplies burn at 50% x N x 4/5 -- a party eats more than one and less than N. The ratio is exact: 0.8 as a float truncates a party of three to 119%, a permanent tax nobody would have found. Solo is untouched, byte for byte. One seat means one build, one INSERT, no participant rows, the same RNG draws in the same order -- the combat characterization golden does not move, and neither does the balance corpus.	2026-07-09 23:23:17 -07:00