3 Commits

Author	SHA1	Message	Date
prosolis	1f211564d9	Review fixes: party close-out, member soft-lock, supply race, elite loot, season crown ... Five bugs found reviewing n1-restoration end to end. beginCombatTurn settles any phase the engine owes before reading whose turn it is. That settle can end the fight — and the old code then answered "you're not in a fight" and returned. The terminal status was already persisted, so nothing ever paid the party out: no XP, no loot, no death recorded, no run teardown. The reaper cannot recover it either, because listExpiredCombatSessions filters on status='active'. Close the fight out there, the way the !fight start path and the reaper already do. A party member was permanently soft-locked when their leader extracted and never resumed. seatedExpeditionFor (the guard) spans 'extracting'; expeditionForMember (what !expedition leave resolved through) saw only 'active'. So the member was refused any new adventure by the guard and told "No active expedition" by the command the guard points them at, with nothing sweeping stale rows and only the leader able to clear one. Resolve the exit through the same lookup as the gate. updateSupplies overwrites supplies_json wholesale, and expeditionCmdAccept folded a member's packs onto a snapshot read before the coin debit, unlocked. Handlers run one goroutine per event, so two invitees accepting genuinely interleave and one member's packs vanish. advUserLock cannot help — it is keyed by sender, so racing members take different mutexes. Add advExpeditionLock and re-read the pool under it. Closes accept-vs-accept; the six other updateSupplies callers still race and are written up separately. runHarvestInterrupt picked an elite enemy and elite narration off a local `elite` flag, then passed a hardcoded false as isElite to closeOutZoneWin. dropZoneLoot gates masterwork on isBoss||isElite, so beating an elite interrupt skipped the masterwork roll and took standard treasure weight — while the same elite fought via !zone paid out correctly. arenaSeasonRollover marked its job complete even when recordArenaSeasonTitle failed, and JobCompleted short-circuits every later run for that quarter, so a transient SQLite BUSY lost the crown forever. Defer completion on failure; the insert is ON CONFLICT DO NOTHING against PRIMARY KEY (season, kind) and a past season's data is frozen, so the retry is safe. Also: drop dead partySurvivors, collapse the zoneCombatRoster alias into fightRoster, route partyCasualtyLine through joinNames, fold four copies of the expedition column projection into expeditionSelectCols, stop replyDM sending a blank DM, and correct two doc comments describing a path that no longer exists. Deliberately not fixed, with reasons, in gogobee_code_review_followups.md — most notably that both turn-based close-outs skip grantCombatAchievements and persistDnDPostCombatSubclass, which the auto-resolve paths run.	2026-07-10 07:20:14 -07:00
prosolis	b333d05443	N3/P6c: a fight the whole party sits down for ... `!fight` seats the expedition's roster instead of the one player who typed it. Seat 0 is the leader, always: the session row is theirs, the lock is theirs, and `!flee`, the fork, and `!extract` stay their call. A monster that wins initiative now swings before anyone speaks. The session layer used to park every new fight on a player_turn, which is true of the hardcoded solo order and a lie about a party's -- the enemy would forfeit round 1 and nobody would notice. `startPartyCombatSession` rolls the order and sets the phase from it; `handleFightCmd` settles the round before it announces, so the opening block narrates the hit rather than quietly showing its damage. Members were invisible to two commands that had no business ignoring them: `!cast` queued a spell for "next combat" while its caster was standing in one, and `!rest` healed a seated member to full mid boss fight. Both now resolve through the party. Nobody leaves without an answer. A downed member's `!fight` opens the party's fight and tells them why they are not in it. The leader's `!extract` reaches everyone it drags out of the dungeon, and everyone rolls for what moved into their house while they were gone. Supplies burn at 50% x N x 4/5 -- a party eats more than one and less than N. The ratio is exact: 0.8 as a float truncates a party of three to 119%, a permanent tax nobody would have found. Solo is untouched, byte for byte. One seat means one build, one INSERT, no participant rows, the same RNG draws in the same order -- the combat characterization golden does not move, and neither does the balance corpus.	2026-07-09 23:23:17 -07:00
prosolis	e8d06195ac	N3/P5: a fight that knows whose turn it is ... A solo fight is a conversation: the player types, the engine answers, and nothing happens in between. A party fight is a queue, and three things follow. Turn ownership. Only the seat on the clock may act, so beginCombatTurn resolves the sender's seat and refuses the rest before anyone spends a slot or burns an item. A fight lock, because three members typing !attack at once took three different user locks and the check would have passed for all three: it takes the fight's lock (keyed on seat 0) then the member's own, always in that order, and a solo fight -- whose owner is the sender, and sync.Mutex is not reentrant -- takes exactly the one lock it always took. And a turn deadline, because one member who wanders off must not freeze the other two for the hour it takes the session reaper to wake up. The deadline is three minutes, not the plan's sixty seconds. The sweep rides the existing one-minute ticker, so any deadline really fires in [d, d+1m); and expeditions here run for days, so the asymmetry favours patience over robbing someone of their boss turn while they read the room on their phone. A lapse latches that seat onto the auto-picker for the rest of the fight, so an absent member costs the party one wait rather than one per round. Typing anything hands the wheel back. Solo is never swept. Three seat-0 leaks fixed on the way past, all of which would have surfaced as the leader quietly doing everyone's business: - mid-fight buffs folded into the session's embedded ActorStatuses, so a member casting Shield on themselves would have armoured the leader; - pickAutoCombatAction read sess.PlayerHP and Statuses.ConcentrationDmg, so playing an away member's turn would have healed the wrong person and re-armed the wrong aura; - runCombatRound rested on any player_turn, and a downed seat still holds one -- the round would have come to rest on a corpse and waited for a dead member to type !attack. settleCombatSession drains it. beginCombatTurn settles before reading the clock, which also fixes a latent solo bug: a fight interrupted mid enemy_turn resumed parked there and silently ate the player's next !attack. The narration turned out to be written in the second person -- "You score 9 damage", "A hit gets through your guard" -- so swapping a name per seat would have told three people they each landed the same blow. A round is rendered once per reader instead: your own events go through the untouched flavor pool, your allies' through a terse third-person summary. CombatEvent carries the seat to make that possible, stamped once per phase step rather than at the twenty-odd append sites in the primitives, which emit against the cursor and know nothing of seats. Closing out fans along the seam the data model already cut. Threat, the zone-kill record, the boss-defeat drop and the run teardown all resolve through getActiveExpedition or getActiveZoneRun, and a member owns neither row -- so they fire once, for the owner. Fanning them out would have tripled the threat a single kill costs. HP, XP, loot and death are the character's, and every seat gets their own. A member can be dead in a fight the party won, so death is read per seat off HP, not off the session's status. The reaper stays attack-only. Finishing an abandoned fight should not quietly burn the player's spell slots and potions; the deadline latch does use the picker, because that member is mid-fight with a party waiting on them. startPartyCombatSession has no production caller yet -- handleFightCmd still opens a solo session. P6 seats the party. TestCombatCharacterization is byte-identical: solo balance did not move.	2026-07-09 22:07:20 -07:00