Close the door the edge gate used to hold
A security review of the whole repo. The queries were already scoped, the
OIDC flow already did state and nonce and PKCE, the session tokens were
already stored as hashes. What it found was mostly the seam between the
code and the deployment — and one place where the deployment quietly
undid the code.
The one that matters: with any AUTHENTIK_* variable missing, Petal fell
back to resolving every request to the single `local` user. That is right
on a laptop and a catastrophe on a public host, and Phase 16 removed the
Traefik basic-auth gate that used to stand behind the mistake. A typo in
the client secret would have served her journals to the open internet and
said so only in a log line nobody reads. It now refuses to start, guarded
by default for any BASE_URL that isn't loopback.
Then the one that would have been fixed and wasn't: stored images now
serve under `default-src 'none'; sandbox`, so an SVG pasted into a
document can't run as a page on Petal's own origin. Traefik's
customresponseheaders *overwrites*, so the CSP declared in the compose
labels would have silently replaced that per-route policy in production.
The whole header block moved into the binary, where a route can tighten
its own and a test can prove it; only HSTS stays at the edge, where TLS
actually terminates.
The rest, smaller:
- PETAL_ALLOWED_SUBS empty means everyone authentik authenticates, and
authentik here fronts half a dozen applications. Still legal, now
said out loud every boot, and set in both env examples.
- LLM failures relayed err.Error() to the browser, which carries the
address of the inference box on the far side of the VPN. Logged
instead; the client only ever rendered "the helper is resting".
- Exports scheme-check their links. Escaping makes a URL safe to sit
in an attribute and says nothing about following it, and an export
is the one artifact here meant to leave. Writing the test found the
markdown image src, which I'd missed reading it.
- The draft rescue is namespaced per account and cleared on sign-out.
Everything else in localStorage is a preference; this is her unsaved
writing, sitting in a profile two people share.
- /auth/logout is POST-only. With SameSite=Lax a GET route lets any
page on the internet sign her out mid-draft.
- Image uploads get a per-account allowance and the TTS cache a size
cap. Both share the encrypted volume the database is on, and a full
disk is SQLite failing to write, not a feature degrading.
- The session cookie takes the __Host- prefix over https, so nothing
else under parodia.dev can plant one. Old cookies still resolve;
nobody is signed out to get there.
- npm audit: linkify-it and postcss.
Verified: go build, go vet, the full Go suite, tsc, 195 frontend tests,
npm audit clean. The startup guard and both CSPs checked against a
running server rather than only asserted.
Claude-Session: https://claude.ai/code/session_016y6gyuHkQXPiEuW8RGQyua
This commit is contained in:
@@ -240,3 +240,85 @@ func TestServeMissing(t *testing.T) {
|
||||
t.Fatalf("expected 404, got %d", rec.Code)
|
||||
}
|
||||
}
|
||||
|
||||
// An SVG is a document, not a picture: it can carry <script>, and this route
|
||||
// serves it from Petal's own origin. Rendered through an <img> that script
|
||||
// never runs, but "open image in new tab" is one click away, and there it
|
||||
// would — with the API of whoever opened it. Every stored image therefore
|
||||
// answers with a CSP that permits nothing.
|
||||
func TestStoredImagesAreServedInert(t *testing.T) {
|
||||
_, alice, _ := newStore(t)
|
||||
|
||||
svg := []byte(`<svg xmlns="http://www.w3.org/2000/svg"><script>fetch('/api/docs')</script></svg>`)
|
||||
rec := httptest.NewRecorder()
|
||||
alice.ServeHTTP(rec, uploadReq(t, "image", svg))
|
||||
if rec.Code != http.StatusOK {
|
||||
t.Fatalf("svg upload code=%d body=%s", rec.Code, rec.Body)
|
||||
}
|
||||
var resp struct{ URL string }
|
||||
if err := json.Unmarshal(rec.Body.Bytes(), &resp); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
name := strings.TrimPrefix(resp.URL, "/api/images/")
|
||||
|
||||
got := get(t, alice, name)
|
||||
if got.Code != http.StatusOK {
|
||||
t.Fatalf("serve code=%d", got.Code)
|
||||
}
|
||||
csp := got.Header().Get("Content-Security-Policy")
|
||||
if !strings.Contains(csp, "default-src 'none'") || !strings.Contains(csp, "sandbox") {
|
||||
t.Fatalf("CSP %q does not neutralize the response", csp)
|
||||
}
|
||||
if got.Header().Get("X-Content-Type-Options") != "nosniff" {
|
||||
t.Fatal("stored images must be served nosniff")
|
||||
}
|
||||
}
|
||||
|
||||
// A per-upload cap bounds one careless paste; nothing bounded ten thousand of
|
||||
// them, on the same volume the database lives on.
|
||||
func TestUploadQuota(t *testing.T) {
|
||||
database, err := db.Open(filepath.Join(t.TempDir(), "test.db"))
|
||||
if err != nil {
|
||||
t.Fatalf("open db: %v", err)
|
||||
}
|
||||
t.Cleanup(func() { database.Close() })
|
||||
if _, err := database.Exec(
|
||||
`INSERT INTO users (id, email, display_name) VALUES (?, ?, ?)`,
|
||||
"bob", "bob@petal.local", "Bob",
|
||||
); err != nil {
|
||||
t.Fatalf("seed second user: %v", err)
|
||||
}
|
||||
h, err := New(t.TempDir(), database.DB, db.LocalUserID)
|
||||
if err != nil {
|
||||
t.Fatalf("new store: %v", err)
|
||||
}
|
||||
alice := auth.Middleware(auth.StaticResolver(db.LocalUserID))(h.Routes())
|
||||
bob := auth.Middleware(auth.StaticResolver("bob"))(h.Routes())
|
||||
|
||||
// Fill Alice's allowance by hand — uploading a gibibyte in a test would be
|
||||
// absurd, and what's under test is the accounting, not the arithmetic.
|
||||
name := upload(t, alice, pngBytes)
|
||||
if _, err := database.Exec(
|
||||
`UPDATE images SET size = ? WHERE user_id = ? AND name = ?`,
|
||||
int64(maxUserBytes), db.LocalUserID, name,
|
||||
); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
// Re-storing something she already has costs nothing, so it still works.
|
||||
if again := upload(t, alice, pngBytes); again != name {
|
||||
t.Fatalf("a re-upload of an owned image should dedupe, got %q", again)
|
||||
}
|
||||
|
||||
// Anything new does not.
|
||||
rec := httptest.NewRecorder()
|
||||
alice.ServeHTTP(rec, uploadReq(t, "image", otherPNG))
|
||||
if rec.Code != http.StatusInsufficientStorage {
|
||||
t.Fatalf("over-quota upload code=%d, want 507", rec.Code)
|
||||
}
|
||||
|
||||
// And it is *her* allowance, not the store's: Bob is unaffected.
|
||||
if got := upload(t, bob, otherPNG); got == "" {
|
||||
t.Fatal("one writer's quota must not stop another writing")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user