d7e63d86a6
Driven in a browser for the first time, which is where three bugs were. Every visit to /games/uno was a 500: the page was never added to the list server.go parses into the games template set, so render() answered "unknown page". The casino tests all call their handlers directly and never go through render(), so nothing saw it. TestEveryCasinoPageRenders now walks the mux and asks for every page the casino routes to. The play script hid the first card that lit up rather than the one you clicked, so playing any other playable card made an innocent card vanish. And on a phone the discard sized its box but not its card, which takes its size from --uno-h, so a full-size card hung out of a small hole and covered the colour in play. Claude-Session: https://claude.ai/code/session_013M5nD7PgUboJXoDcYHzpuJ
51 lines
1.5 KiB
Go
51 lines
1.5 KiB
Go
package web
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// Every page the casino routes to must be in the games template set. This is not
|
|
// a fussy test: uno shipped with its handler wired, its engine tested and its
|
|
// template written, and every visit to the table answered "unknown page" with a
|
|
// 500 — because the page was never added to the list server.go parses. Nothing
|
|
// else caught it, since the other tests call the handlers straight and never go
|
|
// through render(). Add a game, add it here.
|
|
func TestEveryCasinoPageRenders(t *testing.T) {
|
|
s := newCasino(t)
|
|
|
|
pages := []string{
|
|
"/games",
|
|
"/games/blackjack",
|
|
"/games/hangman",
|
|
"/games/solitaire",
|
|
"/games/trivia",
|
|
"/games/uno",
|
|
}
|
|
|
|
mux := http.NewServeMux()
|
|
s.casinoRoutes(mux)
|
|
|
|
for _, path := range pages {
|
|
t.Run(path, func(t *testing.T) {
|
|
w := httptest.NewRecorder()
|
|
mux.ServeHTTP(w, as(t, s, "reala", "GET", path, nil))
|
|
|
|
if w.Code != http.StatusOK {
|
|
t.Fatalf("GET %s = %d, want 200 (body: %s)", path, w.Code, strings.TrimSpace(w.Body.String()))
|
|
}
|
|
// render() writes the 500 as a body and a page that fails halfway
|
|
// through still comes back 200, so look at what was actually served.
|
|
body := w.Body.String()
|
|
if strings.Contains(body, "unknown page") {
|
|
t.Fatalf("GET %s served the unknown-page error: the template is missing from the games set in server.go", path)
|
|
}
|
|
if !strings.Contains(body, "</html>") {
|
|
t.Fatalf("GET %s did not render a whole page (%d bytes) — the template blew up mid-render", path, len(body))
|
|
}
|
|
})
|
|
}
|
|
}
|