Hardware arrives tomorrow, which makes this the blocking work: the appliance has no console, so without it there is no way to answer "is pixel 0 at the end I think it is" except by guessing. Geometric mapping. NOTE_MAP_GEOMETRIC (default on) derives each key from white-key geometry rather than semitone index: 52 white keys span the strip, so a white key is LED_COUNT/52 pixels - about 3.38 at 176 LEDs, not 2 - with black keys on the boundaries. The old linear map drifts within each octave, worst at F, by up to ~0.87 LEDs (~6mm) even after an optimal offset and scale. Set NOTE_MAP_GEOMETRIC=0 to restore it. This exposed a real bug. Under the geometric map adjacent key spans overlap, because the semitone pitch (~1.7 LEDs) is narrower than LEDS_PER_KEY. The renderer painted unlit keys black, so a key erased its lit neighbour's pixels. It now clears once and paints only lit keys. The linear map never overlapped, so this could not have been found without the geometry change. LED_OFFSET shifts every key, absorbing where the strip was actually cut and where the profile ended up. Off-strip pixels are clipped, never wrapped. Calibration patterns, selected by CC 20, with CC 21/22 setting the pixel for the walk: ends (orientation and length), octaves (mapping drift), keys (whole mapping at once), walk (finding LED_OFFSET), all (voltage droop at the far end). Patterns run at the same brightness ceiling as normal operation, so none can exceed the current budget the design already allows. tools/calibrate.sh drives all of it from the PC over ALSA MIDI, and README carries the six-step procedure in dependency order. Verified: tests pass across fourteen configurations, now including both mapping modes and positive, negative and reversed offsets. Both platforms build clean - pianoled.uf2 for RP2350 and both Circle kernel images - with no warnings from project sources. Claude-Session: https://claude.ai/code/session_01TVCB25LBsmeteWvaSMz4Ne
39 lines
1.3 KiB
Bash
Executable File
39 lines
1.3 KiB
Bash
Executable File
#!/bin/sh
|
|
# Host-side tests for the mapping and power-clamp logic.
|
|
# Compiles the real firmware sources against stubbed Circle headers, across
|
|
# every configuration variant that changes the rendering path.
|
|
set -e
|
|
cd "$(dirname "$0")/.."
|
|
OUT=$(mktemp -d)
|
|
trap 'rm -rf "$OUT"' EXIT
|
|
|
|
FAIL=0
|
|
for CFG in \
|
|
"default:" \
|
|
"reversed strip:-DSTRIP_REVERSED=1" \
|
|
"velocity insensitive:-DVELOCITY_SENSITIVE=0" \
|
|
"reversed + velocity insensitive:-DSTRIP_REVERSED=1 -DVELOCITY_SENSITIVE=0" \
|
|
"full brightness:-DGLOBAL_BRIGHTNESS=255" \
|
|
"tight key cap:-DMAX_LIT_KEYS=5" \
|
|
"single LED per key:-DLEDS_PER_KEY=1" \
|
|
"three LEDs per key:-DLEDS_PER_KEY=3" \
|
|
"hints disabled:-DHINT_MIDI_CHANNEL=MIDI_CHANNEL_NONE" \
|
|
"linear map:-DNOTE_MAP_GEOMETRIC=0" \
|
|
"linear map reversed:-DNOTE_MAP_GEOMETRIC=0 -DSTRIP_REVERSED=1" \
|
|
"positive offset:-DLED_OFFSET=3" \
|
|
"negative offset:-DLED_OFFSET=-2" \
|
|
"offset reversed:-DLED_OFFSET=4 -DSTRIP_REVERSED=1" \
|
|
; do
|
|
NAME=${CFG%%:*}
|
|
FLAGS=${CFG#*:}
|
|
printf '\n=== %s ===\n' "$NAME"
|
|
g++ -std=c++17 -Wall -Wextra -Wno-unused-parameter $FLAGS \
|
|
-o "$OUT/t" -Itests/stubs -Isrc \
|
|
tests/test_pianoleds.cpp src/pianoleds.cpp
|
|
"$OUT/t" || FAIL=1
|
|
done
|
|
|
|
printf '\n'
|
|
if [ $FAIL -ne 0 ]; then echo "SOME CONFIGURATIONS FAILED"; exit 1; fi
|
|
echo "all configurations passed"
|