drwily/gogobee
1
0
Fork 0
mirror of https://github.com/prosolis/gogobee.git synced 2026-07-16 08:52:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Combat: TwinBee per-round narration for turn-based fights

Browse Source 
Replace the MVP turn-based round renderer with RenderTurnRound, which
reuses the full auto-resolve narrative pools for shared combat events so
TwinBee's voice is identical across both engines. Only the four
turn-specific actions (flee, spell_held, spell_cast, use_consumable) get
new pools.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
prosolis
2026-05-14 07:53:17 -07:00
parent fd28f31de5
commit 146924818d
3 changed files with 105 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
internal/plugin/combat_cmd_test.go
View File

@@ -235,10 +235,10 @@ func TestRunCombatRound_CastControlSkipsEnemyTurn(t *testing.T) {
}
}
// ── renderCombatRound ──────────────────────────────────────────────────────
// ── RenderTurnRound ────────────────────────────────────────────────────────
func TestRenderCombatRound(t *testing.T) {
if got := renderCombatRound(nil, "Hero", "Goblin"); !strings.Contains(got, "without a clean blow") {
func TestRenderTurnRound(t *testing.T) {
if got := RenderTurnRound(nil, "Hero", "Goblin"); !strings.Contains(got, "without a clean blow") {
t.Errorf("empty events render = %q", got)
}
events := []CombatEvent{
@@ -246,18 +246,28 @@ func TestRenderCombatRound(t *testing.T) {
{Actor: "enemy", Action: "miss"},
{Actor: "enemy", Action: "poison_tick", Damage: 3},
}
got := renderCombatRound(events, "Hero", "Goblin")
if !strings.Contains(got, "Hero") || !strings.Contains(got, "9") {
t.Errorf("player hit not rendered: %q", got)
got := RenderTurnRound(events, "Hero", "Goblin")
// One line per event (damage events interpolate their amount; the random
// pool choice is what varies, so assert structure + the damage numbers
// rather than specific flavor strings).
if lines := strings.Count(got, "\n"); lines != 2 {
t.Errorf("expected 3 lines, got %d: %q", lines+1, got)
}
if !strings.Contains(got, "misses") {
t.Errorf("enemy miss not rendered: %q", got)
if !strings.Contains(got, "9") {
t.Errorf("player hit damage not rendered: %q", got)
}
if !strings.Contains(got, "Poison") {
t.Errorf("poison tick not rendered: %q", got)
if !strings.Contains(got, "3") {
t.Errorf("poison tick damage not rendered: %q", got)
}
// Unknown actor/action with no damage renders nothing (not a blank line).
if line := renderCombatRoundEvent(CombatEvent{Actor: "system", Action: "timeout"}, "Hero", "Goblin"); line != "" {
t.Errorf("unknown zero-damage event should render empty, got %q", line)
// Turn-specific actions get their own pools.
cast := RenderTurnRound([]CombatEvent{
{Actor: "player", Action: "spell_cast", Desc: "Fireball — 24 dmg", Damage: 24},
}, "Hero", "Goblin")
if !strings.Contains(cast, "Fireball — 24 dmg") {
t.Errorf("spell_cast label not rendered: %q", cast)
}
flee := RenderTurnRound([]CombatEvent{{Actor: "player", Action: "flee"}}, "Hero", "Goblin")
if flee == "" || strings.Contains(flee, "without a clean blow") {
t.Errorf("flee should render a line: %q", flee)
}
}