prosolis
d5fecf45d8
Review follow-up: a test seam for outbound messages
...
SendDM/SendMessage went straight through Base to the live client with no
fake, so every handler whose only observable output is a DM stopped below
the test boundary — which is how the party close-out bug (fix #1 ) and the
member soft-lock (fix #2 ) survived a thorough suite: nothing could see what
was, or wasn't, sent.
Add a MessageSink interface and a Base.Sink field. When non-nil it captures
every outbound message — both the DM route (SendDM/SendDMID) and the room
route (SendMessage/SendMessageID, which is what the arena announcement uses)
— and the client is never touched. Nil in production, so behaviour is
unchanged; one seam, no call-site churn, since all 765 send sites are
downstream of these four methods.
Tests (message_sink_test.go): a captureSink double + installSink helper;
TestMessageSink_CapturesDMAndRoom proving both routes divert with the right
target/text and that the *ID variants report an id back; and
TestExpeditionCmdLeave_DMsBothEnds, which drives the real fix-#2 handler end
to end and asserts both DMs land — a path that was a silent no-op in a unit
test before. beginCombatTurn's terminal path and the arena rollover are now
reachable the same way.
Claude-Session: https://claude.ai/code/session_017mEwUmmS7aQTP2NQXj6rUa
2026-07-10 10:44:56 -07:00
..
2026-07-09 20:21:17 -07:00
2026-07-09 19:22:10 -07:00
2026-07-09 19:22:10 -07:00
2026-05-27 19:41:49 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-05-09 14:25:22 -07:00
2026-05-09 14:25:22 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 19:22:10 -07:00
2026-07-10 07:20:14 -07:00
2026-07-09 19:22:10 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-04-26 07:57:31 -07:00
2026-07-10 07:18:07 -07:00
2026-04-08 15:50:28 -07:00
2026-05-12 21:59:19 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 09:12:34 -07:00
2026-07-10 09:12:34 -07:00
2026-05-09 14:25:21 -07:00
2026-07-10 07:18:07 -07:00
2026-05-16 12:40:17 -07:00
2026-07-10 07:18:07 -07:00
2026-04-28 22:37:04 -07:00
2026-04-10 16:50:49 -07:00
2026-05-09 21:32:47 -07:00
2026-04-24 22:23:58 -07:00
2026-04-08 23:01:39 -07:00
2026-07-10 07:18:07 -07:00
2026-04-05 17:04:03 -07:00
2026-04-05 17:04:03 -07:00
2026-04-05 17:04:03 -07:00
2026-05-16 12:40:17 -07:00
2026-05-16 12:40:17 -07:00
2026-07-10 07:18:07 -07:00
2026-05-09 14:25:22 -07:00
2026-03-27 21:26:19 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-05-09 14:25:23 -07:00
2026-07-09 18:29:31 -07:00
2026-07-09 18:29:31 -07:00
2026-07-10 08:55:07 -07:00
2026-05-09 14:25:22 -07:00
2026-07-10 07:18:07 -07:00
2026-05-22 08:42:47 -07:00
2026-05-09 14:25:22 -07:00
2026-05-22 08:42:47 -07:00
2026-07-10 07:18:07 -07:00
2026-05-09 14:25:23 -07:00
2026-05-09 14:25:22 -07:00
2026-05-23 10:30:47 -07:00
2026-07-09 19:22:10 -07:00
2026-05-14 21:19:31 -07:00
2026-07-10 07:18:07 -07:00
2026-05-15 14:43:11 -07:00
2026-07-10 08:55:07 -07:00
2026-07-10 08:55:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 18:29:31 -07:00
2026-07-09 18:29:31 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 08:14:59 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-05-09 14:25:22 -07:00
2026-05-14 15:28:42 -07:00
2026-05-14 15:28:42 -07:00
2026-05-14 15:28:42 -07:00
2026-07-09 20:29:05 -07:00
2026-05-28 21:55:34 -07:00
2026-07-10 07:18:07 -07:00
2026-05-14 18:00:29 -07:00
2026-05-14 18:00:29 -07:00
2026-03-27 21:26:19 -07:00
2026-03-26 09:22:02 -07:00
2026-07-10 07:18:07 -07:00
2026-05-28 09:35:04 -07:00
2026-06-18 06:34:16 -07:00
2026-05-15 12:11:27 -07:00
2026-05-09 14:25:23 -07:00
2026-07-09 19:36:24 -07:00
2026-05-12 21:54:40 -07:00
2026-04-18 01:07:25 -07:00
2026-05-09 17:23:08 -07:00
2026-05-09 14:25:22 -07:00
2026-05-09 14:25:23 -07:00
2026-07-10 08:01:51 -07:00
2026-05-09 14:25:22 -07:00
2026-07-10 08:01:51 -07:00
2026-05-14 07:53:17 -07:00
2026-07-10 08:50:15 -07:00
2026-05-12 21:59:19 -07:00
2026-07-09 20:21:17 -07:00
2026-07-10 07:20:14 -07:00
2026-07-10 08:44:25 -07:00
2026-04-18 01:05:22 -07:00
2026-07-10 08:25:56 -07:00
2026-07-10 08:25:56 -07:00
2026-07-10 08:44:25 -07:00
2026-05-22 09:26:17 -07:00
2026-05-09 14:25:22 -07:00
2026-07-10 08:44:25 -07:00
2026-07-09 21:23:35 -07:00
2026-07-10 08:50:15 -07:00
2026-07-09 23:23:17 -07:00
2026-07-10 08:01:51 -07:00
2026-07-09 23:23:17 -07:00
2026-07-10 07:20:14 -07:00
2026-05-16 12:53:00 -07:00
2026-07-09 22:07:20 -07:00
2026-07-09 20:29:05 -07:00
2026-07-10 08:44:25 -07:00
2026-07-10 08:01:51 -07:00
2026-07-10 08:25:56 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 08:44:25 -07:00
2026-07-09 20:43:37 -07:00
2026-07-10 07:18:07 -07:00
2026-03-26 09:22:02 -07:00
2026-04-08 17:04:40 -07:00
2026-07-10 08:01:51 -07:00
2026-07-10 08:01:51 -07:00
2026-07-10 07:18:07 -07:00
2026-06-18 00:28:05 -07:00
2026-05-12 21:59:19 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 23:23:17 -07:00
2026-05-28 08:14:13 -07:00
2026-07-10 08:01:51 -07:00
2026-05-12 21:59:19 -07:00
2026-07-10 07:18:07 -07:00
2026-05-12 21:59:19 -07:00
2026-05-09 14:25:22 -07:00
2026-07-09 23:56:16 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-05-14 22:37:47 -07:00
2026-05-14 22:37:47 -07:00
2026-05-17 12:24:18 -07:00
2026-05-17 17:03:20 -07:00
2026-05-09 14:25:22 -07:00
2026-05-09 17:21:33 -07:00
2026-07-10 08:01:51 -07:00
2026-05-27 19:41:49 -07:00
2026-07-10 08:14:59 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:20:14 -07:00
2026-06-18 06:34:16 -07:00
2026-07-10 08:01:51 -07:00
2026-07-10 08:14:59 -07:00
2026-05-15 12:11:27 -07:00
2026-07-10 08:14:59 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 23:56:16 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 23:56:16 -07:00
2026-07-09 18:49:19 -07:00
2026-07-10 08:01:51 -07:00
2026-07-10 07:18:07 -07:00
2026-05-16 12:40:17 -07:00
2026-05-15 12:11:27 -07:00
2026-07-10 08:01:51 -07:00
2026-05-09 14:25:22 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:20:14 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-05-09 14:25:22 -07:00
2026-05-27 18:42:57 -07:00
2026-07-10 07:18:07 -07:00
2026-05-21 23:40:54 -07:00
2026-07-10 08:14:59 -07:00
2026-07-10 07:18:07 -07:00
2026-05-09 14:25:21 -07:00
2026-05-15 11:29:03 -07:00
2026-05-09 14:25:21 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-05-14 21:30:15 -07:00
2026-05-12 21:59:19 -07:00
2026-05-17 16:20:10 -07:00
2026-05-09 14:25:22 -07:00
2026-05-14 19:47:01 -07:00
2026-05-17 17:03:20 -07:00
2026-05-17 16:06:46 -07:00
2026-07-09 23:23:17 -07:00
2026-05-14 22:06:31 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 19:22:10 -07:00
2026-05-09 14:25:21 -07:00
2026-07-10 07:18:07 -07:00
2026-05-09 14:25:21 -07:00
2026-05-09 14:25:21 -07:00
2026-07-10 08:25:56 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-05-14 21:30:15 -07:00
2026-05-09 14:25:21 -07:00
2026-05-15 14:43:11 -07:00
2026-05-14 21:53:06 -07:00
2026-05-14 15:18:18 -07:00
2026-05-27 22:00:02 -07:00
2026-05-09 14:25:21 -07:00
2026-05-09 14:25:22 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 08:25:56 -07:00
2026-05-09 14:25:21 -07:00
2026-05-09 14:25:22 -07:00
2026-05-14 18:38:57 -07:00
2026-05-16 12:40:17 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 23:56:16 -07:00
2026-05-09 14:25:22 -07:00
2026-07-10 09:12:34 -07:00
2026-05-09 14:25:22 -07:00
2026-07-10 06:32:29 -07:00
2026-05-09 15:17:30 -07:00
2026-05-09 14:25:22 -07:00
2026-05-09 14:25:22 -07:00
2026-05-17 17:03:20 -07:00
2026-05-09 14:25:22 -07:00
2026-07-09 18:29:31 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 23:56:16 -07:00
2026-05-12 21:59:19 -07:00
2026-07-10 07:18:07 -07:00
2026-05-27 17:24:36 -07:00
2026-07-10 07:18:07 -07:00
2026-05-27 18:13:33 -07:00
2026-07-10 07:18:07 -07:00
2026-06-28 17:39:29 -07:00
2026-04-08 17:04:40 -07:00
2026-07-10 07:18:07 -07:00
2026-05-16 12:40:17 -07:00
2026-07-10 08:01:51 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 08:01:51 -07:00
2026-05-27 19:07:37 -07:00
2026-05-27 19:48:44 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 08:01:51 -07:00
2026-07-09 22:30:11 -07:00
2026-07-09 22:30:11 -07:00
2026-07-09 23:56:16 -07:00
2026-07-09 22:18:40 -07:00
2026-07-10 07:20:14 -07:00
2026-07-10 08:55:07 -07:00
2026-07-10 08:55:07 -07:00
2026-07-10 00:37:59 -07:00
2026-05-27 20:47:28 -07:00
2026-07-10 00:37:59 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-03-26 23:38:06 -07:00
2026-05-21 18:05:37 -07:00
2026-07-10 07:18:07 -07:00
2026-05-21 18:05:37 -07:00
2026-05-22 07:25:08 -07:00
2026-03-26 09:22:02 -07:00
2026-05-21 22:58:31 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-04-18 01:06:50 -07:00
2026-03-26 09:22:02 -07:00
2026-03-26 09:22:02 -07:00
2026-05-09 14:25:21 -07:00
2026-03-26 09:22:02 -07:00
2026-03-26 09:22:02 -07:00
2026-04-18 14:11:59 -07:00
2026-05-27 18:42:57 -07:00
2026-04-18 14:11:59 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-03-10 16:58:15 -07:00
2026-04-26 10:09:32 -07:00
2026-07-09 18:52:32 -07:00
2026-07-09 18:52:32 -07:00
2026-07-10 07:18:07 -07:00
2026-04-08 17:04:40 -07:00
2026-05-09 14:25:21 -07:00
2026-05-09 14:25:21 -07:00
2026-07-09 18:32:23 -07:00
2026-07-09 19:22:10 -07:00
2026-07-10 08:55:07 -07:00
2026-05-14 22:37:47 -07:00
2026-05-14 18:00:29 -07:00
2026-05-14 18:00:29 -07:00
2026-03-27 21:26:19 -07:00
2026-03-27 11:55:47 -07:00
2026-07-10 10:44:56 -07:00
2026-07-10 07:18:07 -07:00
2026-04-08 17:04:40 -07:00
2026-07-10 07:18:07 -07:00
2026-04-08 17:04:40 -07:00
2026-05-09 14:25:23 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 10:44:56 -07:00
2026-05-15 08:03:42 -07:00
2026-05-09 14:25:23 -07:00
2026-05-09 14:25:23 -07:00
2026-03-11 00:45:25 -07:00
2026-03-08 18:25:18 -07:00
2026-03-27 11:55:47 -07:00
2026-03-26 09:22:02 -07:00
2026-03-10 18:08:05 -07:00
2026-04-08 17:04:40 -07:00
2026-07-10 07:18:07 -07:00
2026-03-08 18:25:18 -07:00
2026-07-10 07:18:07 -07:00
2026-05-12 21:59:19 -07:00
2026-07-10 07:18:07 -07:00
2026-03-26 09:22:02 -07:00
2026-03-11 00:45:25 -07:00
2026-04-10 16:50:49 -07:00
2026-03-08 18:25:18 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-07-09 18:52:32 -07:00
2026-04-08 17:04:40 -07:00
2026-04-26 10:09:32 -07:00
2026-03-11 00:45:25 -07:00
2026-03-29 16:24:59 -07:00
2026-03-26 09:22:02 -07:00
2026-07-10 07:18:07 -07:00
2026-04-10 16:50:49 -07:00
2026-03-29 16:24:59 -07:00
2026-07-10 07:18:07 -07:00
2026-06-03 17:23:53 -07:00
2026-04-08 15:24:49 -07:00
2026-07-10 07:20:14 -07:00
2026-07-10 08:01:51 -07:00
2026-05-28 20:00:09 -07:00
2026-05-28 20:00:09 -07:00
2026-07-10 07:18:07 -07:00
2026-05-27 17:32:29 -07:00
2026-05-28 20:00:09 -07:00
2026-05-28 20:00:09 -07:00
2026-05-28 20:00:09 -07:00
2026-05-28 20:00:09 -07:00
2026-05-27 17:32:29 -07:00
2026-05-27 17:32:29 -07:00
2026-05-27 17:24:36 -07:00
2026-05-27 17:24:36 -07:00
2026-05-27 17:46:38 -07:00
2026-05-27 17:46:38 -07:00
2026-05-09 16:41:46 -07:00
2026-05-21 23:56:18 -07:00
2026-07-10 07:18:07 -07:00
2026-07-10 07:18:07 -07:00
2026-05-27 17:32:29 -07:00
2026-05-27 17:32:29 -07:00
2026-05-28 19:02:58 -07:00
2026-05-28 20:00:09 -07:00
2026-05-28 20:00:09 -07:00
2026-05-27 17:46:38 -07:00
2026-05-27 17:46:38 -07:00
2026-05-27 17:24:36 -07:00
2026-07-09 19:36:24 -07:00
2026-07-09 19:47:16 -07:00
2026-07-09 23:56:16 -07:00